Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1791850: [release-4.1] Update license year #1236

Closed
wants to merge 1 commit into from
Closed

Bug 1791850: [release-4.1] Update license year #1236

wants to merge 1 commit into from

Conversation

Bowenislandsong
Copy link
Member

this commit updates the license year from 2019 to 2020 and unblocks PRs that fails on the verify test.

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

update license year
432b964 
this commit updates the license year from 2019 to 2020 and unblocks PRs that fails on the verify test.
@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

update license year

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 15, 2020
@Bowenislandsong Bowenislandsong changed the title update license year [release-4.1] update license year Jan 15, 2020
@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.1] update license year

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bowenislandsong Bowenislandsong changed the title [release-4.1] update license year [release-4.1] Update license year Jan 15, 2020
@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.1] Update license year

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bowenislandsong
Copy link
Member Author

/retest

@Bowenislandsong
Copy link
Member Author

/test unit

@dinhxuanvu dinhxuanvu self-requested a review January 15, 2020 21:10
@dinhxuanvu dinhxuanvu self-assigned this Jan 15, 2020
@dinhxuanvu
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2020
@dinhxuanvu
Copy link
Member

/approve

@jpeeler
Copy link
Contributor

jpeeler commented Jan 15, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bowenislandsong, dinhxuanvu, jpeeler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@Bowenislandsong
Copy link
Member Author

@operator-framework/patch-managers Could I get help to skip bugzilla + cherry-pick labels and merge this license year update PR? Thank you!

@Bowenislandsong Bowenislandsong changed the title [release-4.1] Update license year Bug 1791850: [release-4.1] Update license year Jan 16, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 16, 2020
@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: This pull request references Bugzilla bug 1791850, which is invalid:

  • expected dependent Bugzilla bug 1791887 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1791850: [release-4.1] Update license year

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bowenislandsong
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: This pull request references Bugzilla bug 1791850, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bowenislandsong
Copy link
Member Author

v

@Bowenislandsong
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Collaborator

@Bowenislandsong: This pull request references Bugzilla bug 1791850, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 19, 2020
@crawford
Copy link

Copyright years listed in source aren't generally updated after creation; certainly not in a release branch.

@openshift-ci-robot
Copy link
Collaborator

@crawford: Closed this PR.

In response to this:

Copyright years listed in source aren't generally updated after creation; certainly not in a release branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu approved these changes

Assignees

@dinhxuanvu dinhxuanvu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Bowenislandsong @openshift-ci-robot @dinhxuanvu @jpeeler @crawford